-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT of simplify-implication
RPC endpoint
#239
Draft
geo2a
wants to merge
28
commits into
main
Choose a base branch
from
georgy/simplify-implication
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove obsolete substitutor * update haskell.nix nad haskell-backend in the lock
…plify-implication
geo2a
force-pushed
the
georgy/simplify-implication
branch
from
July 24, 2023 07:14
2e5ac7e
to
42c9c44
Compare
geo2a
force-pushed
the
georgy/simplify-implication
branch
from
July 25, 2023 15:46
f69de20
to
56c35eb
Compare
geo2a
force-pushed
the
georgy/simplify-implication
branch
2 times, most recently
from
July 28, 2023 14:12
53de170
to
49c4e83
Compare
geo2a
force-pushed
the
georgy/simplify-implication
branch
from
August 9, 2023 12:56
8af8b5b
to
e3eb94c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements runtimeverification/haskell-backend#3787
Needs:
kore-rpc-types
(part ofhaskell-backend
) that specify the new RPC types: Types specifying thesimplify-implication
RPC endpoint haskell-backend#3614This PR is a bare-bones implementation of the new
simplify-implication
RPC endpoint. We currently only returnImplicationValid
if the antecedent matches consequent and the constrains are empty. If matching is failing we returnImplicationInvalid
. Otherwise,ImplicationUnknown
.Note that the diff is so big because the PR a new Kore definition
simplify-implication.kore
for integration tests.